-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow keyboard navigation #1480
Conversation
eb34cb2
to
1f69a3a
Compare
1f69a3a
to
5e677c4
Compare
5e677c4
to
3b4451c
Compare
3b4451c
to
625293a
Compare
625293a
to
41b24a7
Compare
41b24a7
to
301449a
Compare
301449a
to
033aff7
Compare
033aff7
to
313257e
Compare
Also when picking what folders of my phone to sync, my choice isn't taken into account when leaving the screen using the keyboard to click on the top left cross. I don't even get how this is possible |
Also when previewing a file in the view pager, I can't seem to reach to top toolbar with the keyboard |
When navigating inside folders and then navigating back up a level, the folder I just left is not selected anymore. Do you think it would be possible to select again the folder "we came from"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left the comments about the most important behaviors I've seen
Summary: |
4c722f4
to
fcef70e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the toolbar of the fragment_ment_gallery is not accessible
app/src/main/java/com/infomaniak/drive/views/PreviewHeaderView.kt
Outdated
Show resolved
Hide resolved
8cee737
to
67b88bd
Compare
67b88bd
to
6629933
Compare
6629933
to
7514298
Compare
|
Remove all keyboard traps and ensure that all interactive elements are focusable.